Re: [PATCH] D17727: Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency.

2016-03-01 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17727: Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency.

2016-03-01 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 49470. ioeric marked 5 inline comments as done. ioeric added a comment. - Fixed commenting. http://reviews.llvm.org/D17727 Files: include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h lib/Format/Format.cpp

Re: [PATCH] D17727: Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency.

2016-03-01 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include/clang/Format/Format.h:734-736 @@ -733,1 +733,5 @@ +/// \brief Return replacements that are merged from orginal replacements +/// and the replacements for formatting the code after applying the orginal +/// replacements.

[PATCH] D17727: Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency.

2016-02-29 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added a reviewer: klimek. ioeric added subscribers: klimek, cfe-commits. Merge branch 'master' of http://llvm.org/git/clang Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency. http://reviews.llvm.org/D17727 Files: