Re: [PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-19 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl-AMD abandoned this revision. kzhuravl-AMD added a comment. After recent discussions we decided to use target specific options instead http://reviews.llvm.org/D17764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-08 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Attribute side of things LGTM, but I don't have the expertise to comment on the OpenCL functionality itself. http://reviews.llvm.org/D17764

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-08 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl-AMD marked an inline comment as done. kzhuravl-AMD added a comment. http://reviews.llvm.org/D17764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-08 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl-AMD updated this revision to Diff 50067. kzhuravl-AMD added a comment. Aaron's Review Comments http://reviews.llvm.org/D17764 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-07 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl-AMD updated this revision to Diff 49990. kzhuravl-AMD added a comment. Review Feedback - Updated diff http://reviews.llvm.org/D17764 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-07 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl-AMD marked 2 inline comments as done. kzhuravl-AMD added a comment. http://reviews.llvm.org/D17764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-07 Thread Tom Stellard via cfe-commits
tstellarAMD added inline comments. Comment at: include/clang/Basic/AttrDocs.td:969-973 @@ +968,7 @@ + +Clang supports the ``__attribute__((amdgpu_tools_num_reserved_vgpr()))`` +attribute on AMD Southern Islands GPUs and later. If specified, it causes AMD +GPU Backend to reserve

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-03 Thread Matt Arsenault via cfe-commits
arsenm added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1601 @@ +1600,3 @@ +if (CodeGenOpts.AMDGPUToolsInsertNopsOpt) + FuncAttrs.addAttribute("amdgpu_tools_insert_nops"); +if (CodeGenOpts.AMDGPUToolsNumReservedVGPROpt) Yes

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-02 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl-AMD updated this revision to Diff 49652. kzhuravl-AMD added a comment. Review Feedback - Updated diff http://reviews.llvm.org/D17764 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-01 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Some quick thoughts below. Comment at: include/clang/Basic/Attr.td:997 @@ +996,3 @@ + let Subjects = SubjectList<[Function], ErrorDiag, + "ExpectedKernelFunction">; +} I don't see any code that checks

[PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-01 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl-AMD created this revision. kzhuravl-AMD added reviewers: arsenm, tstellarAMD. kzhuravl-AMD added a subscriber: cfe-commits. Add following kernel function attributes for AMD GPU Tools (debugger, profiler): - amdgpu_tools_insert_nops - insert two nop instructions for each high level