Re: [PATCH] D17775: Add a few dllimport/dllexport tests. NFC

2016-03-01 Thread Reid Kleckner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL262442: Add a few dllimport/dllexport tests. NFC (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D17775?vs=49510&id=49570#toc Repository: rL LLVM http://reviews.llvm.org/D17775

Re: [PATCH] D17775: Add a few dllimport/dllexport tests. NFC

2016-03-01 Thread Sean Silva via cfe-commits
On Tue, Mar 1, 2016 at 1:00 PM, Warren Ristow < warren_ris...@playstation.sony.com> wrote: > wristow added a comment. > > In http://reviews.llvm.org/D17775#365611, @silvas wrote: > > > Random question: > > > > > We plan to enable dllimport/dllexport support for the PS4 > > > > > > How are you plan

Re: [PATCH] D17775: Add a few dllimport/dllexport tests. NFC

2016-03-01 Thread Warren Ristow via cfe-commits
wristow added a comment. In http://reviews.llvm.org/D17775#365611, @silvas wrote: > Random question: > > > We plan to enable dllimport/dllexport support for the PS4 > > > How are you planning on codegenning them? The same way as we do in our > private branch? Yes, that's the intention. http:

Re: [PATCH] D17775: Add a few dllimport/dllexport tests. NFC

2016-03-01 Thread Sean Silva via cfe-commits
silvas added a subscriber: silvas. silvas added a comment. Random question: > We plan to enable dllimport/dllexport support for the PS4 How are you planning on codegenning them? The same way as we do in our private branch? http://reviews.llvm.org/D17775 ___

[PATCH] D17775: Add a few dllimport/dllexport tests. NFC

2016-03-01 Thread Warren Ristow via cfe-commits
wristow created this revision. wristow added reviewers: cfe-commits, rnk, majnemer. This change just adds tests for some corner cases of dllimport/dllexport, primarily for some static methods. We plan to enable dllimport/dllexport support for the PS4, and these additional tests are for points we