Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

This revision was automatically updated to reflect the committed changes. Closed by commit rL263647: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the… (authored by swiftix). Changed prior to commit: http://reviews.llvm.org/D18025?vs=50508=50838#toc Repository: rL

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D18025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

swiftix updated this revision to Diff 50508. swiftix added a comment. This patch revision addresses all issues mentioned by reviewers: - DocCatCallingConvs is used instead of DocCatVariable. - ObjectiveC is replaced by Objective-C in the docs. - Tests for preserve_most and preserve_all are

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

swiftix added inline comments. Comment at: include/clang/Basic/Attr.td:1394 @@ -1393,1 +1393,3 @@ +def PreserveMost : InheritableAttr { + let Spellings = [GNU<"preserve_most">]; aaron.ballman wrote: > Do these attributes do anything on targets other than

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

swiftix added a comment. Thanks for the hint about adding subscribers, because I was not aware it is possible in the Web-GUI. That was the reason why a new review was created. And thanks for the comments. I'll address your comments and upload the new patch for review.

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

aaron.ballman added a comment. In http://reviews.llvm.org/D18025#373373, @cfe-commits wrote: > Could you review this simple patch? Is it OK to merge or are there any > changes to be made? The usual rule of thumb is to wait about a week before pinging a review -- sometimes the backlogs for

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

Hi Aaron, Hi Juergen, Could you review this simple patch? Is it OK to merge or are there any changes to be made? Thanks, Roman > On Mar 9, 2016, at 7:25 PM, Roman Levenstein wrote: > > swiftix created this revision. > swiftix added reviewers: ributzka, aaron.ballman.

[PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

swiftix created this revision. swiftix added reviewers: ributzka, aaron.ballman. swiftix added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Till now, preserve_mostcc/preserve_allcc calling convention attributes were only available at the LLVM IR level. This patch adds