Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-23 Thread Matt Kulukundis via cfe-commits
fowles added a comment. thank you! Repository: rL LLVM http://reviews.llvm.org/D18149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-23 Thread Haojian Wu via cfe-commits
hokein added a comment. @fowles, I have commit the patch for you. Repository: rL LLVM http://reviews.llvm.org/D18149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-23 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264146: Add check for unneeded copies of locals (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D18149?vs=51289=51391#toc Repository: rL LLVM http://reviews.llvm.org/D18149

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-22 Thread Matt Kulukundis via cfe-commits
fowles updated this revision to Diff 51289. fowles added a comment. rebased to latest. Can someone submit this for me I don't have commit bits. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-22 Thread Matt Kulukundis via cfe-commits
fowles added inline comments. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21 @@ +20,3 @@ + +void recordFixes(const VarDecl , ASTContext , + DiagnosticBuilder ) { I am inclined to just leave it as is for the moment, this is

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-22 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. LG Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21 @@ +20,3 @@ + +void recordFixes(const VarDecl , ASTContext , + DiagnosticBuilder ) { nit: Alternatively, you could

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-22 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D18149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-21 Thread Matt Kulukundis via cfe-commits
fowles updated this revision to Diff 51215. fowles marked 2 inline comments as done. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-21 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:87 @@ +86,3 @@ + +namespace { +void recordFixes(const VarDecl , ASTContext , I prefer to move the anonymous namespace under `namespace performance {` statement.

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-19 Thread Matt Kulukundis via cfe-commits
fowles updated this revision to Diff 50879. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-19 Thread Matt Kulukundis via cfe-commits
fowles updated this revision to Diff 50878. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-19 Thread Matt Kulukundis via cfe-commits
fowles updated this revision to Diff 50927. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-15 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Thank you for the patch! Looks mostly good, a few style nits. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21 @@ -20,2 +20,3 @@ using namespace ::clang::ast_matchers; +using clang::tidy::decl_ref_expr_utils::isOnlyUsedAsConst;

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-15 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Please always add 'cfe-commits' to Subscribers when you send a patch for review (I've added it now). Substantial comments later. http://reviews.llvm.org/D18149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org