Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Thanks Jordan. r264025. > On Mar 21, 2016, at 1:08 PM, Jordan Rose wrote: > > Yes, that looks good. For bonus points, add a similar test using the new > property syntax > > @property (class) NSBundle *foo2; > > instead of the method. (I expect that version to behave

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Yes, that looks good. For bonus points, add a similar test using the new property syntax @property (class) NSBundle *foo2; instead of the method. (I expect that version to behave nearly the same, including the "may" in the diagnostic.) Jordan > On Mar 21, 2016, at 12:36, Akira Hatanaka

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Jordan,Does the attached patch look OK?On Mar 18, 2016, at 1:19 PM, Jordan Rose wrote:No, that case worked already. The case you fixed is the one where Base is 'foo' and Property is 'prop'…and actually, thinking more about it, this should not be considered "exact". *sigh*

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Thanks Jordan. I’ve committed the patch in r263818. I didn’t understand your comment on WeakObjectProfileTy’s table (I’m assuming you are talking about the table in ScopeInfo.h:183). It looks like the entry MyClass.prop in the table already covers the case this patch fixed (in the test case I

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL263818: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo. (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D18268?vs=51025=51056#toc Repository: rL LLVM

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

No, that case worked already. The case you fixed is the one where Base is 'foo' and Property is 'prop'…and actually, thinking more about it, this should not be considered "exact". *sigh* The point of "exact" is "if you see this Base and Property again, are you sure it's really the same Base?".

[PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

ahatanak created this revision. ahatanak added a reviewer: jordan_rose. ahatanak added a subscriber: cfe-commits. The crash occurs in WeakObjectProfileTy::getBaseInfo when getBase() is called on an ObjCPropertyRefExpr object whose receiver is an interface. This patch fixes the crash by checking

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. Ah, of course! Thanks for catching this, Akira. Can you add this case to the table in the doc comment for WeakObjectProfileTy? (That's how I convinced myself it was correct.)