Re: [PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

2016-09-10 Thread Daniel Jasper via cfe-commits
djasper closed this revision. djasper marked 6 inline comments as done. djasper added a comment. Submitted as r263943. Comment at: include/clang/Format/Format.h:415 @@ +414,3 @@ + /// as the "main" include in both a.cc and a_test.cc. + std::string IncludeMainRegex; +

Re: [PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

2016-03-21 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include/clang/Format/Format.h:415 @@ +414,3 @@ + /// as the "main" include in both a.cc and a_test.cc. + std::string IncludeMainRegex; + djasper wrote: > I chose this name for better alphabetical ordering. I don't

Re: [PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

2016-03-21 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: include/clang/Format/Format.h:415 @@ +414,3 @@ + /// as the "main" include in both a.cc and a_test.cc. + std::string IncludeMainRegex; + I chose this name for better alphabetical ordering. I don't strongly lean either

Re: [PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

2016-03-21 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: include/clang/Format/Format.h:415 @@ +414,3 @@ + /// as the "main" include in both a.cc and a_test.cc. + std::string IncludeMainRegex; + I'd

Re: [PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

2016-03-21 Thread Daniel Jasper via cfe-commits
djasper updated this revision to Diff 51154. http://reviews.llvm.org/D18313 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/FormatTest.cpp unittests/Format/SortIncludesTest.cpp Index: unittests/Format/SortIncludesTest.cpp

[PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

2016-03-21 Thread Daniel Jasper via cfe-commits
djasper created this revision. djasper added a reviewer: klimek. djasper added a subscriber: cfe-commits. Herald added a subscriber: klimek. This patch adds a regular expression to configure suffixes of an included file to check whether it is the "main" include of the current file. Previously,