Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

2016-04-18 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. LGTM http://reviews.llvm.org/D18398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

2016-04-18 Thread Andrey Turetskiy via cfe-commits
aturetsk added a comment. Ping. http://reviews.llvm.org/D18398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

2016-04-06 Thread Andrey Turetskiy via cfe-commits
aturetsk added a comment. Hi Bruno, Thanks for the review. Comment at: include/clang/Driver/Options.td:1281 @@ -1280,1 +1280,3 @@ +def miamcu : Flag<["-"], "miamcu">, Group, Flags<[DriverOption, CoreOption]>, + HelpText<"Use Intel MCU ABI">; def malign_functions_EQ :

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

2016-04-06 Thread Andrey Turetskiy via cfe-commits
aturetsk updated this revision to Diff 52789. aturetsk added a comment. Fix remarks, http://reviews.llvm.org/D18398 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/miamcu-opt.c Index: test/Driver/miamcu-opt.c

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

2016-04-04 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a subscriber: bruno. bruno added a comment. Hi Andrey, Comment at: include/clang/Driver/Options.td:1281 @@ -1280,1 +1280,3 @@ +def miamcu : Flag<["-"], "miamcu">, Group, Flags<[DriverOption, CoreOption]>, + HelpText<"Use Intel MCU ABI.">; def malign_functions_EQ

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

2016-04-04 Thread Andrey Turetskiy via cfe-commits
aturetsk added a comment. Ping. http://reviews.llvm.org/D18398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18398: Compilation for Intel MCU (Part 1/3)

2016-03-23 Thread Andrey Turetskiy via cfe-commits
aturetsk created this revision. aturetsk added reviewers: rsmith, tra, thakis, ddunbar, bob.wilson, dougk. aturetsk added subscribers: cfe-commits, zinovy.nis, DavidKreitzer. Add -miamcu option which: * Sets IAMCU triple * Sets IAMCU ABI * Enforces static compilation