Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-05 Thread Paul Robinson via cfe-commits
probinson added a subscriber: probinson. probinson added a comment. In http://reviews.llvm.org/D18708#390166, @rsmith wrote: > we'll likely be changing the default C++ language mode soon.) Privately, PS4 defaults to C++11; we haven't sent that patch upstream because it would make tests fail

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-05 Thread Warren Ristow via cfe-commits
wristow added a subscriber: wristow. wristow added a comment. In http://reviews.llvm.org/D18708#390183, @dyung wrote: > In http://reviews.llvm.org/D18708#390166, @rsmith wrote: > > > In http://reviews.llvm.org/D18708#390150, @dyung wrote: > > > > > From my understanding, there are 2 issues that b

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-04 Thread Richard Smith via cfe-commits
On Fri, Apr 1, 2016 at 6:43 PM, Douglas Yung < douglas_y...@playstation.sony.com> wrote: > dyung added a comment. > > In http://reviews.llvm.org/D18708#390166, @rsmith wrote: > > > In http://reviews.llvm.org/D18708#390150, @dyung wrote: > > > > > From my understanding, there are 2 issues that bloc

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-04 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265359: Set the default C standard to C99 when targeting the PS4. (authored by ssrivastava). Changed prior to commit: http://reviews.llvm.org/D18708?vs=52622&id=52633#toc Repository: rL LLVM http://

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-04 Thread Yunzhong Gao via cfe-commits
ygao accepted this revision. ygao added a reviewer: ygao. ygao added a comment. The test LGTM. Thanks! http://reviews.llvm.org/D18708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-04 Thread Douglas Yung via cfe-commits
dyung updated this revision to Diff 52622. dyung added a comment. Moved the test to test/Preprocessor as suggested by Gao and found a nice place to add it. http://reviews.llvm.org/D18708 Files: include/clang/Frontend/CompilerInvocation.h lib/Frontend/CompilerInvocation.cpp test/Preproces

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-01 Thread Douglas Yung via cfe-commits
dyung added a comment. In http://reviews.llvm.org/D18708#390166, @rsmith wrote: > In http://reviews.llvm.org/D18708#390150, @dyung wrote: > > > From my understanding, there are 2 issues that block us. The first is that > > we currently do not ship all of the header files for C11. The second is

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-01 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D18708#390150, @dyung wrote: > From my understanding, there are 2 issues that block us. The first is that we > currently do not ship

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-01 Thread Douglas Yung via cfe-commits
dyung added a comment. In http://reviews.llvm.org/D18708#390132, @rsmith wrote: > What's the motivation for this change? Clang's C11 mode should accept all > code accepted by its C99 mode (and conversely, most or perhaps all of the C11 > language features are accepted by default in C99 mode as

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-01 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith added a comment. What's the motivation for this change? Clang's C11 mode should accept all code accepted by its C99 mode (and conversely, most or perhaps all of the C11 language features are accepted by default in C99 mode as an extension). Is the probl

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-01 Thread Yunzhong Gao via cfe-commits
ygao added a subscriber: ygao. Comment at: test/Driver/ps4-misc-defaults.cpp:10 @@ +9,2 @@ +// RUN: %clang -target x86_64-scei-ps4 -E -x c -dM %s | FileCheck -check-prefix=CHECK-CSTD %s +// CHECK-CSTD: __STDC_VERSION__ 199901L It seems to me that this part of the

[PATCH] D18708: Set C99 as default C Standard for PS4 target

2016-04-01 Thread Yung, Douglas via cfe-commits
Forwarding to cfe-commits as I don't think I saw it appear there. > dyung created this revision. > > On the PS4, the default C standard is C99 which differs from the > current default of C11. This patch makes the default C99 when targeting > the PS4. > > http://reviews.llvm.org/D18708 > > Files