alexfh added a comment.
Sorry for the delay. Your patch was lost in my inbox. Feel free to ping me
earlier.
Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37
@@ +36,3 @@
+
+It turns out that the common bug is to have function returning only bools
Prazek added inline comments.
Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37
@@ +36,3 @@
+
+It turns out that the common bug is to have function returning only bools but
having int as return type.
+If check finds case like this then it function
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37
@@ +36,3 @@
+
+It turns out that the common bug is to have function returning only bools but
having int as
Prazek updated this revision to Diff 58961.
Prazek added a comment.
aborting with virtual functions
http://reviews.llvm.org/D18821
Files:
clang-tidy/CMakeLists.txt
clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp
clang-tidy/bugprone/BoolToIntegerConversionCheck.h
Prazek updated this revision to Diff 58309.
Prazek added a comment.
Some small bugfixes afeter running it on llvm
http://reviews.llvm.org/D18821
Files:
clang-tidy/CMakeLists.txt
clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp
clang-tidy/bugprone/BoolToIntegerConversionCheck.h
Prazek updated this revision to Diff 58148.
Prazek added a comment.
+Fixed bug with operators
+ added fixup for function return type
I will post changes on clang tomorrow
http://reviews.llvm.org/D18821
Files:
clang-tidy/CMakeLists.txt
clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:43
@@ +42,3 @@
+
+This is because z and ``true`` will be implicitly converted to int by
promotion.
+To get rid of
Prazek added a comment.
Updated the diff with changes
http://reviews.llvm.org/D19105
http://reviews.llvm.org/D18821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits