hokein added a comment.
@michael_miller
You fixing is not completed. The crash still happens, the test case see
https://llvm.org/bugs/show_bug.cgi?id=27419.
Could you please take a look on it? Thanks very much.
Repository:
rL LLVM
http://reviews.llvm.org/D19270
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266862: Fix a crash in
cppcoreguidelines-pro-type-member-init related to missing… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19270?vs=54210=54327#toc
Repository:
rL LLVM
hokein accepted this revision.
hokein added a comment.
LGTM. Thanks.
http://reviews.llvm.org/D19270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
michael_miller added a comment.
In http://reviews.llvm.org/D19270#405805, @alexfh wrote:
> LG. Do you need me to submit the patch?
Yeah, that's be awesome—thanks!
http://reviews.llvm.org/D19270
___
cfe-commits mailing list
alexfh accepted this revision.
alexfh added a comment.
LG. Do you need me to submit the patch?
http://reviews.llvm.org/D19270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D19270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
michael_miller created this revision.
michael_miller added reviewers: alexfh, aaron.ballman, hokein.
michael_miller added a subscriber: cfe-commits.
Fixes a crash in cppcoreguidelines-pro-type-member-init when checking some
record types with a constructor without a body. We now check to make
