apelete updated this revision to Diff 56253.
apelete added a comment.
[scan-build] fix warnings emitted on Clang Sema code base
Changes since last revision:
- split patch into Sema changes unit to ease review process,
- cherry-pick Sema changes from http://reviews.llvm.org/D19084,
- cherry-pick
apelete added a reviewer: pcc.
apelete added a comment.
Waiting for review, could someone please have a look at this one ?
http://reviews.llvm.org/D19278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
apelete updated this revision to Diff 55747.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Changes since last revision:
- fast forward rebase on git master branch.
http://reviews.llvm.org/D19278
Files:
lib/AST/ExprConstant.cpp
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:696
@@ -695,1 +695,3 @@
+assert(ArgExpr && "cannot get the type of a NULL expression");
+
LGTM
http://reviews.llvm.org/D19278
rjmccall added a comment.
LGTM, thanks.
http://reviews.llvm.org/D19278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apelete marked an inline comment as done.
apelete added a comment.
http://reviews.llvm.org/D19278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apelete updated this revision to Diff 54269.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Following changes were done since last revision:
- lib/Sema/SemaOverload.cpp: avoid interleaving (FromExpr) and
(!FromExpr->isLValue()) conditions in if()
rjmccall added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:9191
@@ -9189,1 +9190,3 @@
+ ToTy->isLValueReferenceType() &&
+ !FromExpr->isLValue() &&
ToTy.getNonReferenceType().getCanonicalType() ==
apelete updated this revision to Diff 54246.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Following changes were done since last revision:
- fix a typo in lib/Sema/SemaDeclCXX.cpp: decalration ==> declaration.
http://reviews.llvm.org/D19278
Files:
mgrang added a subscriber: mgrang.
Comment at: lib/Sema/SemaDeclCXX.cpp:438
@@ +437,3 @@
+ assert(New && "New function decalration is NULL, aborting merge.");
+ assert(Old && "Old function decalration is NULL, aborting merge.");
+
typo: decalration ==>
apelete created this revision.
apelete added a subscriber: cfe-commits.
This partch fixes a few "Logic error" warnings of the type "Called c++
object pointer is null" reported by Clang Static Analyzer on the
following files:
- lib/AST/ExprConstant.cpp,
- lib/CodeGen/CGDebugInfo.cpp,
-
11 matches
Mail list logo