rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/AST/ASTImporter.cpp:2253-2254
@@ +2252,4 @@
+ return nullptr;
+ }
+ else {
+ToRequiresClause = nullptr;
`else` on same line as `}` please.
https://reviews.
hubert.reinterpretcast added a comment.
Ping.
http://reviews.llvm.org/D19322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast added a comment.
Ping (#2).
http://reviews.llvm.org/D19322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast updated this revision to Diff 57216.
hubert.reinterpretcast added a comment.
Set requires-clause when creating TemplateParameterLists; NFC
Removes the default argument for the requires-clause constraint expression in
TemplateParameterList::Create.
An appropriate argument
hubert.reinterpretcast added a comment.
Ping.
http://reviews.llvm.org/D19322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast marked 2 inline comments as done.
hubert.reinterpretcast added a comment.
@rsmith; I've addressed Faisal's comment. Please let me know if this patch (and
http://reviews.llvm.org/D19770) is good to go. If it isn't ready yet, I'd like
your opinion on http://reviews.llvm.org/
hubert.reinterpretcast updated this revision to Diff 55850.
hubert.reinterpretcast added a comment.
Address Faisal's comment; supercedes http://reviews.llvm.org/D19771
Replaces the custom FixedSizeTemplateParameterListStorage implementation with
one that follows the interface provided by llvm::T
hubert.reinterpretcast added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:175
@@ -152,2 +174,3 @@
+ Expr *RequiresClause;
public:
faisalv wrote:
> Yuk - this entire guy (FizedSizeTemplateParameterListStorage) seems quite
> fragile (dependent
faisalv added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:175
@@ -152,2 +174,3 @@
+ Expr *RequiresClause;
public:
Yuk - this entire guy (FizedSizeTemplateParameterListStorage) seems quite
fragile (dependent on object layout) - are the gains
hubert.reinterpretcast updated this revision to Diff 54456.
hubert.reinterpretcast added a comment.
Actually add parens this time
http://reviews.llvm.org/D19322
Files:
include/clang/AST/DeclTemplate.h
lib/AST/DeclTemplate.cpp
lib/Sema/SemaTemplateDeduction.cpp
Index: lib/Sema/SemaTemplat
hubert.reinterpretcast updated this revision to Diff 54455.
hubert.reinterpretcast added a comment.
Store the RequiresClause expression into the created storage;
add accessor;
add unnecessary parens to silence warning
http://reviews.llvm.org/D19322
Files:
include/clang/AST/DeclTemplate.h
li
11 matches
Mail list logo
