Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

This revision was automatically updated to reflect the committed changes. Closed by commit rL266992: [Clang-tidy] Fix for crash in modernize-raw-string-literal check (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D19331?vs=54401=54504#toc Repository: rL LLVM

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

edyp87 added a comment. Yes, please apply this patch for me. As for macro cases - I also thought about this but check's author has taken care of macros in `check()` method : void RawStringLiteralCheck::check(const MatchFinder::MatchResult ) { [...] if

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

edyp87 marked an inline comment as done. edyp87 added a comment. 1. Extended diff has been generated - sorry, I am new to Phabricator. 2. AST for this case looks like this: > AST for crashing case: > > -VarDecl 0x2b27370 col:19 function 'const char *const' > callinit >

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

edyp87 removed rL LLVM as the repository for this revision. edyp87 updated this revision to Diff 54401. edyp87 added a comment. Extended diff range + removed unnecessary variable. http://reviews.llvm.org/D19331 Files: clang-tidy/modernize/RawStringLiteralCheck.cpp

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thank you for the explanation! The change looks good now. Do you need me to submit the patch for you? As for other cases that can lead to this, it might be possible to achieve the same

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

alexfh added a comment. 1. Please generate diffs with full context when sending patches. Use any of the methods described in http://llvm.org/docs/Phabricator.html. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:111 @@ -110,2 +110,3 @@ void

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

alexfh added a comment. (hit Submit early...) 2. How does AST look for these test cases? I wonder whether there are any similar cases not covered by PredefinedExpr. And thank you for the patch! Repository: rL LLVM http://reviews.llvm.org/D19331