Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL268065: Add a Subjects line to NoDebugAttr [NFC]. (authored by probinson). Changed prior to commit: http://reviews.llvm.org/D19689?vs=55482=55618#toc Repository: rL LLVM

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

On Fri, Apr 29, 2016 at 12:24 PM, Paul Robinson wrote: > probinson added a comment. > > I'll proceed from here without doing anything about the inconsistencies, > because this particular one should go away and you're already doing something > about the rest of it. I

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

probinson added a comment. I'll proceed from here without doing anything about the inconsistencies, because this particular one should go away and you're already doing something about the rest of it. Comment at: include/clang/Basic/Attr.td:977 @@ -976,1 +976,3 @@ + let

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

ks, > > --paulr > > > > *From:* David Blaikie [mailto:dblai...@gmail.com] > *Sent:* Thursday, April 28, 2016 4:26 PM > *To:* reviews+d19689+public+514682b5314c5...@reviews.llvm.org; Robinson, > Paul > *Cc:* Aaron Ballman; cfe-commits > *Subject:* Re: [PATCH] D19689

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This turns out to be a bit of a mess: Alias and NoDebug use the same diagnostic kind text, neither of which match the actual subject list. Alias doesn't appertain to an obj-c

RE: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

tweak, I'd like to know about it. Thanks, --paulr From: David Blaikie [mailto:dblai...@gmail.com] Sent: Thursday, April 28, 2016 4:26 PM To: reviews+d19689+public+514682b5314c5...@reviews.llvm.org; Robinson, Paul Cc: Aaron Ballman; cfe-commits Subject: Re: [PATCH] D19689: Add Subjects to NoDebugAtt

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

LGTM On Thu, Apr 28, 2016 at 2:10 PM, Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > probinson created this revision. > probinson added a reviewer: aaron.ballman. > probinson added a subscriber: cfe-commits. > > The 'nodebug' attribute had hand-coded constraints; replace

[PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

probinson created this revision. probinson added a reviewer: aaron.ballman. probinson added a subscriber: cfe-commits. The 'nodebug' attribute had hand-coded constraints; replace those with a Subjects line in Attr.td. Also add a missing test to verify the attribute is okay on an Objective-C