Anastasia closed this revision.
Anastasia added a comment.
r269305
https://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
In http://reviews.llvm.org/D19780#442305, @rivanvx wrote:
> @Anastasia I looked into introducing a separate getOpenCLVersion() function
> (or perhaps three - major version, minor version and version string). This
> would have to be used in lib/CodeGen/TargetInfo.cpp a
rivanvx added a comment.
@Anastasia I looked into introducing a separate getOpenCLVersion() function (or
perhaps three - major version, minor version and version string). This would
have to be used in lib/CodeGen/TargetInfo.cpp and lib/Parse/ParseDecl.cpp, and
I am undecided on where should one
Anastasia added a comment.
Sure. Committed in r269305!
Thanks!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rivanvx added a comment.
Could we solve that at a later point? There is one more place where such code
is already used, but this would enlarge the scope of this patch.
If yes, I am wiling to factor it out after this is merged.
http://reviews.llvm.org/D19780
_
Anastasia added a comment.
Sure! Will do! Thanks!
I am thinking to factor out the version computation string into a common
function, because we might use it in the other places too.
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-c
rivanvx added a comment.
Please, can anyone push this?
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rivanvx added a comment.
Thanks for the reviews!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
Please, move cfe-commits to Subscribers list!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 accepted this revision.
pxli168 added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
rivanvx updated this revision to Diff 56479.
rivanvx added a comment.
Make that int const as well.
http://reviews.llvm.org/D19780
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Parse/ParseDecl.cpp
test/Parser/opencl-cl20.cl
test/Parser/opencl-storage-class.cl
test/SemaOpenCL/in
rivanvx added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:3519
@@ +3518,3 @@
+ / 100);
+const char *VerSpec = (VerMajor + std::string (".") +
VerMinor).c_str();
+Diag(Tok, DiagID) << VerSpec << PrevSpec << isS
rivanvx updated this revision to Diff 56478.
rivanvx marked 3 inline comments as done.
rivanvx added a comment.
I am neither aware how to convert ints to StringRef nor how to concatenate
StringRefs. Apologies if I missed something in the API.
In any case, this approach looks pretty clean to me.
rivanvx added a comment.
@Anastasia would you still prefer to make VerSpec a std::string?
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:3519
@@ +3518,3 @@
+ / 100);
+const char *VerSpec = (VerMajor + std::string (".") +
VerMinor).c_str();
+Diag(Tok, DiagID) << VerSpec << PrevSpec << i
Anastasia added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:3519
@@ +3518,3 @@
+ / 100);
+const char *VerSpec = (VerMajor + std::string (".") +
VerMinor).c_str();
+Diag(Tok, DiagID) << VerSpec << PrevSpec << i
17 matches
Mail list logo