Re: [PATCH] D20034: [CUDA] Only __shared__ variables can be static local on device side.

2016-05-10 Thread Justin Lebar via cfe-commits
jlebar added a comment. This patch regresses Eigen, because it raises an error even on host+device functions. Repository: rL LLVM http://reviews.llvm.org/D20034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20034: [CUDA] Only __shared__ variables can be static local on device side.

2016-05-09 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL268962: [CUDA] Only __shared__ variables can be static local on device side. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D20034?vs=56610=56611#toc Repository: rL LLVM

Re: [PATCH] D20034: [CUDA] Only __shared__ variables can be static local on device side.

2016-05-09 Thread Artem Belevich via cfe-commits
tra updated this revision to Diff 56610. tra added a comment. Updated tests in CodeGenCUDA/address-spaces.cu http://reviews.llvm.org/D20034 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/CodeGenCUDA/address-spaces.cu test/CodeGenCUDA/device-var-init.cu

Re: [PATCH] D20034: [CUDA] Only __shared__ variables can be static local on device side.

2016-05-06 Thread Artem Belevich via cfe-commits
tra added a comment. In http://reviews.llvm.org/D20034#423945, @jlebar wrote: > What are we supposed to do if we encounter a static __shared__ variable in an > HD function? Presumably that also should be an error if we invoke the HD > function from the device? nvcc produces an error only of

Re: [PATCH] D20034: [CUDA] Only __shared__ variables can be static local on device side.

2016-05-06 Thread Justin Lebar via cfe-commits
jlebar added a comment. What are we supposed to do if we encounter a static __shared__ variable in an HD function? Presumably that also should be an error if we invoke the HD function from the device? http://reviews.llvm.org/D20034 ___

[PATCH] D20034: [CUDA] Only __shared__ variables can be static local on device side.

2016-05-06 Thread Artem Belevich via cfe-commits
tra created this revision. tra added reviewers: jingyue, jlebar. tra added a subscriber: cfe-commits. According to CUDA programming guide (v7.5): > E.2.9.4: Within the body of a __device__ or __global__ function, only > __shared__ variables may be declared with static storage class.