This revision was automatically updated to reflect the committed changes.
Closed by commit rL270108: [CUDA] Do not allow non-empty destructors for global
device-side variables. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D20140?vs=56829&id=57849#toc
Repository:
rL LLV
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
lgtm, but I'd like Richard to sign off on this too.
Comment at: lib/Sema/SemaDecl.cpp:10438
@@ -10437,1 +10437,3 @@
+ // Also make sure that destructor, ifthere is one,
tra created this revision.
tra added reviewers: jlebar, rsmith, jingyue.
tra added a subscriber: cfe-commits.
According to Cuda Programming guide (v7.5, E2.3.1):
> __device__, __constant__ and __shared__ variables defined in namespace
> scope, that are of class type, cannot have a non-empty constr