faisalv resigned from this revision.
faisalv removed a reviewer: faisalv.
faisalv added a comment.
Should be fixed by: http://reviews.llvm.org/D19783.
Thanks again for your feedback and all the time you put into this =)
http://reviews.llvm.org/D20349
faisalv added a comment.
That feedback would be greatly appreciated - thanks Taewook!
Faisal Vali
http://reviews.llvm.org/D20349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh added a comment.
Thank you for your comments. @faisalv, it is great that you already submitted a
patch. Let me see if your patch resolves the issue I have. Thanks!
http://reviews.llvm.org/D20349
___
cfe-commits mailing list
Thanks for the work here - but this bug is a duplicate of this:
https://llvm.org/bugs/show_bug.cgi?id=27507, which unearthed some
other subtle bugs with the cv capture of *this by copy.
I've submitted a patch for review here: http://reviews.llvm.org/D19783
that addresses both issues - about 2-3
The patch'll need a test case (in clang/tests) - I've not looked at the
change/have much opinion there, just suggesting adding a test at minimum so
when someone does come to review it it's more complete/closer to/ready to
commit.
On Tue, May 17, 2016 at 9:23 PM, Taewook Oh via cfe-commits <
twoh created this revision.
twoh added reviewers: faisalv, rsmith.
twoh added a subscriber: cfe-commits.
(This is a fix for Bug 27797 https://llvm.org/bugs/show_bug.cgi?id=27797).
Currently when RebuildLambdaScopeInfo() function in lib/Sema/SemaDecl.cpp
observes lambda capturing 'this', it
