pcc updated this revision to Diff 59260.
pcc marked 2 inline comments as done.
pcc added a comment.
- Address review comments
http://reviews.llvm.org/D20415
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.cpp
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3427
@@ -3425,3 +3426,3 @@
DContext, DeclName, LinkageName, Unit, LineNo, getOrCreateType(T,
Unit),
-Var->hasInternalLinkage(), Var,
+Var->hasInternalLinkage(), nullptr,
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
LGTM with small changes.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3427
@@ -3425,3 +3426,3 @@
DContext, DeclName, LinkageName, Unit, LineNo, getOrCreateType(T,
pcc added a comment.
Ping.
http://reviews.llvm.org/D20415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3477
@@ -3473,1 +3476,3 @@
+InitExpr =
+DBuilder.createConstantValueExpression(Init.getInt().getExtValue());
GV.reset(DBuilder.createGlobalVariable(
pcc wrote:
> aprantl wrote:
pcc added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3477
@@ -3473,1 +3476,3 @@
+InitExpr =
+DBuilder.createConstantValueExpression(Init.getInt().getExtValue());
GV.reset(DBuilder.createGlobalVariable(
aprantl wrote:
> pcc wrote:
> >
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3477
@@ -3473,1 +3476,3 @@
+InitExpr =
+DBuilder.createConstantValueExpression(Init.getInt().getExtValue());
GV.reset(DBuilder.createGlobalVariable(
pcc wrote:
> aprantl wrote:
pcc added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3477
@@ -3473,1 +3476,3 @@
+InitExpr =
+DBuilder.createConstantValueExpression(Init.getInt().getExtValue());
GV.reset(DBuilder.createGlobalVariable(
aprantl wrote:
> Are we
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3393
@@ +3392,3 @@
+DContext, FieldName, LinkageName, Unit, LineNo, FieldTy,
+Var->hasInternalLinkage(), nullptr, nullptr);
+Var->addDebugInfo(GV);
aprantl wrote:
> Is
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3393
@@ +3392,3 @@
+DContext, FieldName, LinkageName, Unit, LineNo, FieldTy,
+Var->hasInternalLinkage(), nullptr, nullptr);
+Var->addDebugInfo(GV);
Is there a good reason
pcc planned changes to this revision.
pcc added a comment.
One thing that I forgot to do here was to add a test covering my changes to
`CGDebugInfo::EmitGlobalVariable`. I'll do that momentarily.
http://reviews.llvm.org/D20415
___
cfe-commits
pcc created this revision.
pcc added reviewers: dexonsmith, dblaikie, aprantl.
pcc added a subscriber: cfe-commits.
http://reviews.llvm.org/D20415
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.cpp
12 matches
Mail list logo