Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. See https://github.com/include-what-you-use/include-what-you-use/issues/292 and https://github.com/include-what-you-use/include-what-you-use/issues/301. Repository: rL LLVM http://reviews.llvm.org/D20714 ___ cfe-c

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

etienneb added a comment. In http://reviews.llvm.org/D20714#445911, @Eugene.Zelenko wrote: > There is a way to tell IWYU about compound headers with pragmas > . > I also suggested to make this possible

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. There is a way to tell IWYU about compound headers with pragmas . I also suggested to make this possible via file with compound headers list. But person who knows LLVM/C

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

etienneb added a comment. In http://reviews.llvm.org/D20714#444802, @Eugene.Zelenko wrote: > Point of Include What You Use suggestions to rely on explicit dependencies, > not implicit ones. It's true most of the time. In some case, splitting the header file is for maintainability and includin

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. Point of Include What You Use suggestions to rely on explicit dependencies, not implicit ones. Comment at: clang-tidy/utils/OptionsUtils.cpp:1 @@ -1,2 +1,2 @@ //===--- DanglingHandleCheck.cpp - clang-tidy--===// //

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

etienneb added a comment. drive-by Comment at: clang-tidy/ClangTidy.cpp:24 @@ -24,2 +23,3 @@ #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Frontend/ASTConsumers.h" +#include "clang/Basic/DiagnosticOptions.h" +#include "clang/Basic/FileManager.h" ---

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko updated this revision to Diff 58803. Eugene.Zelenko added a comment. More diff content. Repository: rL LLVM http://reviews.llvm.org/D20714 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticCo

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

alexfh added a comment. Full context diffs, please. See http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface for instructions. Repository: rL LLVM http://reviews.llvm.org/D20714 ___ cfe-commits mailing list cfe-commit

[PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, hokein, etienneb. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLV