hokein updated this revision to Diff 59187.
hokein added a comment.
Always escape headers.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-fixer.py
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D20827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:160
@@ +159,3 @@
+ for (const auto : Context.Headers) {
+// Escape double quote.
+if (Header.front() == '"')
I think we should do the escaping always and not just when
hokein updated this revision to Diff 59185.
hokein added a comment.
Use llvm::yaml::escape to escape double quote.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
bkramer added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:160
@@ +159,3 @@
+ for (const auto : Context.Headers) {
+// Escape double quote.
+if (Header.front() == '"')
Can you just llvm::yaml::escape the string?
hokein updated this revision to Diff 59184.
hokein added a comment.
Show error message when clang-include-fixer died with a fatal error.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
hokein marked 2 inline comments as done.
hokein added a comment.
http://reviews.llvm.org/D20827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 59183.
hokein added a comment.
Get rid of yaml dependency, using json module.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
hokein updated this revision to Diff 59100.
hokein added a comment.
Remove unused code.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-fixer.py
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
And some improvements:
* Show better error messages on unfound symbols.
* Fix a typo.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
10 matches
Mail list logo