Re: [PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

> On Jun 1, 2016, at 1:18 PM, Richard Smith via cfe-commits > wrote: > > On Wed, Jun 1, 2016 at 12:42 PM, Manman Ren via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > manmanren added a comment. > > In http://reviews.llvm.org/D20844#445762 >

Re: [PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

On Wed, Jun 1, 2016 at 12:42 PM, Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > manmanren added a comment. > > In http://reviews.llvm.org/D20844#445762, @rjmccall wrote: > > > Hmm. No, I think the original code is correct here — RangeEnd is a > token range, and those are genera

Re: [PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

manmanren added a comment. In http://reviews.llvm.org/D20844#445762, @rjmccall wrote: > Hmm. No, I think the original code is correct here — RangeEnd is a token > range, and those are generally inclusive rather than exclusive. The fix-it > needs to be inserting at the end of the token. We c

Re: [PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

rjmccall added a comment. Hmm. No, I think the original code is correct here — RangeEnd is a token range, and those are generally inclusive rather than exclusive. The fix-it needs to be inserting at the end of the token. http://reviews.llvm.org/D20844 _

[PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

manmanren created this revision. manmanren added a reviewer: rjmccall. manmanren added a subscriber: cfe-commits. Before this fix, both the start and the end point to the same location, and we will add the FixIt before the type name: ^(NSView view) to ^(*NSView view) After this commit, fixit wil