Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

2016-06-03 Thread Bruno Cardoso Lopes via cfe-commits
bruno closed this revision. bruno added a comment. Applied your suggestions and committed in r271755! Thanks http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

2016-06-02 Thread Ben Langmuir via cfe-commits
benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM. Some minor suggestions. Comment at: include/llvm/Support/LockFileManager.h:87 @@ +86,3 @@ + + /// \brief Get error message + std::string getErrorMessage() c

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

2016-06-02 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a subscriber: llvm-commits. bruno added a comment. Adding the right list for this +llvm-commits http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D20942: [LockFileManager] Improve error output by adding error messages

2016-06-02 Thread Bruno Cardoso Lopes via cfe-commits
bruno created this revision. bruno added a reviewer: benlangmuir. bruno added subscribers: cfe-commits, dexonsmith. This is currently used by clang to lock access to modules; improve the error message so that clang can use better output messages from locking error issues. http://reviews.llvm.or