Re: [PATCH] D20979: [OpenCL] Use function attribute/metadata to represent kernel attributes

2016-06-09 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. In http://reviews.llvm.org/D20979#452616, @yaxunl wrote: > In http://reviews.llvm.org/D20979#452463, @Anastasia wrote: > > > Looking good generally, I am just not sure about mixing two different > > representations. > > > If we choose only one form of representation,

Re: [PATCH] D20979: [OpenCL] Use function attribute/metadata to represent kernel attributes

2016-06-08 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. In http://reviews.llvm.org/D20979#452463, @Anastasia wrote: > Looking good generally, I am just not sure about mixing two different > representations. If we choose only one form of representation, would you suggest to use function metadata or function attribute?

Re: [PATCH] D20979: [OpenCL] Use function attribute/metadata to represent kernel attributes

2016-06-08 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. Looking good generally, I am just not sure about mixing two different representations. http://reviews.llvm.org/D20979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20979: [OpenCL] Use function attribute/metadata to represent kernel attributes

2016-06-03 Thread Yaxun Liu via cfe-commits
yaxunl created this revision. yaxunl added reviewers: Anastasia, bader, pxli168. yaxunl added subscribers: cfe-commits, tstellarAMD. This patch attempts to use target-dependent function attribute to represent reqd_work_group_size, work_group_size_hint and vector_type_hint kernel attributes and