chapuni added a subscriber: chapuni.
chapuni added a comment.
FYI :)
--- a/clang/test/CoverageMapping/unused_function.cpp
+++ b/clang/test/CoverageMapping/unused_function.cpp
@@ -3,34 +3,34 @@
#define START_SCOPE {
#define END_SCOPE }
-// CHECK: _Z2f0v:
+// CHECK:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271969: [Coverage] Fix an assertion failure if the
definition of an unused function… (authored by ikudrin).
Changed prior to commit:
http://reviews.llvm.org/D20997?vs=59806=59818#toc
Repository:
rL
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D20997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ikudrin updated the summary for this revision.
ikudrin removed rL LLVM as the repository for this revision.
ikudrin updated this revision to Diff 59806.
ikudrin added a comment.
- Use `StartFileID` and `EndFileID` variables to eliminate redundant calls to
`SM.getFileID()`.
- Add comment strings
vsk added a comment.
Thanks, this looks good overall. I just have a few minor comments.
Comment at: lib/CodeGen/CoverageMappingGen.cpp:329
@@ +328,3 @@
+ FileID ParentFile = SM.getFileID(Start);
+ while (ParentFile != SM.getFileID(End) && !isNestedIn(End, ParentFile))
ikudrin created this revision.
ikudrin added reviewers: vsk, bogner, davidxl.
ikudrin added a subscriber: cfe-commits.
ikudrin set the repository for this revision to rL LLVM.
We had an assertion failure if, for example, the definition of an unused inline
function starts
in one macro and ends in
