Re: [PATCH] D21141: [DebugInfo] Add calling conventions to DISubroutineType

2016-06-08 Thread Reid Kleckner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272198: [DebugInfo] Add calling conventions to DISubroutineType (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D21141?vs=60055=60101#toc Repository: rL LLVM

Re: [PATCH] D21141: [DebugInfo] Add calling conventions to DISubroutineType

2016-06-08 Thread Adrian Prantl via cfe-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Function pointers make sense to me, thanks! LGTM Comment at: lib/CodeGen/CGDebugInfo.cpp:834 @@ -833,1 +833,3 @@ +static unsigned getDwarfCC(CallingConv CC) { + switch

Re: [PATCH] D21141: [DebugInfo] Add calling conventions to DISubroutineType

2016-06-08 Thread Reid Kleckner via cfe-commits
rnk added a comment. In http://reviews.llvm.org/D21141#452517, @aprantl wrote: > Assuming that we could usually get the calling convention from the Function — > what's the motivation for emitting the calling convention of a subprogram > that has been optimized away? I don't have any

[PATCH] D21141: [DebugInfo] Add calling conventions to DISubroutineType

2016-06-08 Thread Reid Kleckner via cfe-commits
rnk created this revision. rnk added reviewers: aprantl, dblaikie. rnk added a subscriber: cfe-commits. rnk added a dependency: D21114: [DebugInfo] Add calling convention support for DWARF and CodeView. This should have been a very simple change, but it was greatly complicated by the