This revision was automatically updated to reflect the committed changes.
Closed by commit rL272840: [x86] translate SSE packed FP comparison builtins to
IR (authored by spatel).
Changed prior to commit:
http://reviews.llvm.org/D21268?vs=60473=60905#toc
Repository:
rL LLVM
spatel added a comment.
In http://reviews.llvm.org/D21268#455679, @RKSimon wrote:
> Eeep that's certainly a lot more work than just adding a few extra cases!
> Please add a TODO explaining what we need to do?
I don't know what the answer is yet...looks like this is going to require (a
lot
RKSimon added a comment.
Eeep that's certainly a lot more work than just adding a few extra cases!
Please add a TODO explaining what we need to do?
If there is a problem with the header documentation please can you raise a
bugzilla and CC Katya Romanova.
http://reviews.llvm.org/D21268
spatel added a comment.
In http://reviews.llvm.org/D21268#455668, @RKSimon wrote:
> Is there any reason that we shouldn't include the avxintrin.h
> __builtin_ia32_cmppd/__builtin_ia32_cmpps/__builtin_ia32_cmppd256/__builtin_ia32_cmpps256
> packed intrinsics in this CGBuiltin.cpp patch? Since
RKSimon added a comment.
Is there any reason that we shouldn't include the avxintrin.h
__builtin_ia32_cmppd/__builtin_ia32_cmpps/__builtin_ia32_cmppd256/__builtin_ia32_cmpps256
packed intrinsics in this CGBuiltin.cpp patch? Since we're heading towards
nixing them anyhow.
spatel created this revision.
spatel added reviewers: craig.topper, RKSimon, ab.
spatel added a subscriber: cfe-commits.
Herald added a subscriber: mcrosier.
As noted in the code comment, a potential follow-on would be to remove the
builtins themselves. Other than ord/unord, this already works
