This revision was automatically updated to reflect the committed changes.
Closed by commit rL273311: [x86] AVX FP compare builtins should require AVX
target feature (PR28112) (authored by spatel).
Changed prior to commit:
http://reviews.llvm.org/D21306?vs=60596=61437#toc
Repository:
rL LLVM
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM - the compile warning is clear and it could be a problem if we allow
undefined values through on pre-AVX targets.
The only other thing we could do is handle these in CGBuiltin and
RKSimon added a comment.
It seems like part of the need for this is because the _mm_cmp_ps style
intrinsics are defined as macros (to get around the problem of trying to use an
immediate as an argument):
#define _mm_cmp_ps(a, b, c) __extension__ ({ \
spatel added a comment.
In http://reviews.llvm.org/D21306#456965, @echristo wrote:
> The 128 bit versions should only be selecting for sse functions and shouldn't
> need avx to work? What instructions are getting emitted here?
No, the 128-bit versions of these C intrinsics are strictly for
echristo added a comment.
The 128 bit versions should only be selecting for sse functions and shouldn't
need avx to work? What instructions are getting emitted here?
http://reviews.llvm.org/D21306
___
cfe-commits mailing list
spatel created this revision.
spatel added reviewers: echristo, bogner, RKSimon.
spatel added a subscriber: cfe-commits.
Herald added subscribers: mehdi_amini, mcrosier.
This is a fix for PR28112:
https://llvm.org/bugs/show_bug.cgi?id=28112
The FP comparison intrinsics that take an immediate
