Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-07-01 Thread Pirama Arumuga Nainar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274409: Add TargetInfo for 32-bit and 64-bit RenderScript (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21334?vs=62520&id=62581#toc Repository: rL LLVM http://reviews.llvm.

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-07-01 Thread Eric Christopher via cfe-commits
echristo added a comment. In http://reviews.llvm.org/D21334#472548, @pirama wrote: > Reformatted with clang-format for just the parts I added. I ignored > clang-format-suggested changes in code unrelated to this patch. Yep. > Is there a policy or practise on periodically fixing format-relate

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-07-01 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 62520. pirama added a comment. Reformatted with clang-format for just the parts I added. I ignored clang-format-suggested changes in code unrelated to this patch. Is there a policy or practise on periodically fixing format-related issues? If not, I can forma

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-30 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Please reformat with clang-format and then OK. -eric http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-29 Thread Pirama Arumuga Nainar via cfe-commits
pirama added a comment. Ping... http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 60735. pirama added a comment. - revise test http://reviews.llvm.org/D21334 Files: lib/Basic/Targets.cpp test/CodeGen/renderscript.c Index: test/CodeGen/renderscript.c === --- /dev/null +++

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama added a comment. This patch is based on the discussion in http://reviews.llvm.org/D20709. http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama added a comment. http://reviews.llvm.org/D21333 is the corresponding patch to LLVM http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama created this revision. pirama added reviewers: rsmith, echristo. pirama added subscribers: srhines, cfe-commits. Herald added subscribers: mehdi_amini, danalbert, tberghammer, aemerson. The TargetInfo for 'renderscript32' and 'renderscript64' ArchTypes are subclasses of ARMleTargetInfo and