Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r273354. http://reviews.llvm.org/D21345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

2016-06-14 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT added a comment. I gotta wait for them, I don't have commit access. :-> (Nor do I need it at the moment) Haven't encountered problems with those locale tests yet, although I'm still processing 670-ish compiletime and runtime failures. http://reviews.llvm.org/D21345 ___

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

2016-06-14 Thread Ben Craig via cfe-commits
bcraig added a comment. LGTM. I don't see anything controversial here. If you want to wait for @EricWF or @mclow.lists though, that's fine. http://reviews.llvm.org/D21345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

2016-06-14 Thread Ben Craig via cfe-commits
bcraig added a subscriber: bcraig. bcraig added a comment. > Even though they have artificial blocks in order to keep variables locally > scoped, this gives MSVC's /analyze a headache, because it views main() as > consuming an enormous amount of stack space (it doesn't reuse stack, at least > f