Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

kimgr added a comment. This is probably not the right place for this discussion, but I thought I'd offer one more note. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {}

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + kimgr wrote: > mclow.lists wrote: > > mclow.lists wrote: > > > kimgr

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

kimgr added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + mclow.lists wrote: > mclow.lists wrote: > > kimgr wrote: > > > mclow.lists

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + mclow.lists wrote: > kimgr wrote: > > mclow.lists wrote: > > > kimgr

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + kimgr wrote: > mclow.lists wrote: > > kimgr wrote: > > > I'm working

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

kimgr added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + mclow.lists wrote: > kimgr wrote: > > I'm working from the paper at

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + kimgr wrote: > I'm working from the paper at

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

kimgr added a subscriber: kimgr. kimgr added a comment. Inline question on ctor+nullptr Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + I'm working

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists accepted this revision. mclow.lists added a reviewer: mclow.lists. mclow.lists added a comment. This revision is now accepted and ready to land. Landed as revision 276238. https://reviews.llvm.org/D21459 ___ cfe-commits mailing list

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

EricWF added inline comments. Comment at: include/__string:710 @@ +709,3 @@ + +#if _LIBCPP_STD_VER > 11 +template > This declaration should be exposed in all dialects since parts of iomanip depend on it. https://reviews.llvm.org/D21459

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added inline comments. Comment at: include/string:3216 @@ -3668,3 +3215,3 @@ { -return _VSTD::__str_find_last_not_of +return __str_find_last_not_of (data(), size(),

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

EricWF added a comment. The ` bits LGTM. Comment at: include/string_view:209 @@ +208,3 @@ + { +// _LIBCPP_ASSERT(__len == 0 || __s != nullptr, "string_view::string_view(_CharT *, size_t): received nullptr"); + } I think we have two

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

EricWF added a comment. Why did you remove the `_VSTD` qualified on most of the `__str_find` function calls? I think that should be a qualified call because a UDT traits type can hijack overload resolution. (Although __str_find* is a reserved name). I'm happy with the changes to ``. Moving

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

EricWF added a comment. FYI this patch adds 6 new symbols to the dylib: Symbol added: _ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEE7replaceEmmNS_17basic_string_viewIcS2_EEmm {'type': 'FUNC', 'name':

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added inline comments. Comment at: test/std/strings/string.view/string.view.template/nothing_to_do.pass.cpp:10 @@ +9,3 @@ + +#include + This should be `` http://reviews.llvm.org/D21459 ___ cfe-commits

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added a comment. I know that there are more tests needed. http://reviews.llvm.org/D21459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits