Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added a comment. Thanks for the review; Committed. http://reviews.llvm.org/D21666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

rnk accepted this revision. rnk added a comment. lgtm http://reviews.llvm.org/D21666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added a comment. Ping. http://reviews.llvm.org/D21666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra updated this revision to Diff 61851. sivachandra added a comment. Improve global type handling. http://reviews.llvm.org/D21666 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/QualTypeNames.cpp unittests/Tooling/QualTypeNamesTest.cpp Index: unittests/Tooling

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added a comment. PTAL Comment at: lib/Tooling/Core/QualTypeNames.cpp:435 @@ -399,1 +434,3 @@ + // Create a nested name specifier if needed. Prefix = createNestedNameSpecifierForScopeOf(Ctx, QT.getTypePtr(), + true /*F

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra updated this revision to Diff 61837. sivachandra added a comment. Address comments. http://reviews.llvm.org/D21666 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/QualTypeNames.cpp unittests/Tooling/QualTypeNamesTest.cpp Index: unittests/Tooling/QualTypeNam

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added inline comments. Comment at: lib/Tooling/Core/QualTypeNames.cpp:405 @@ -398,3 +404,3 @@ // is not the global scope. Prefix = createNestedNameSpecifierForScopeOf(Ctx, QT.getTypePtr(), true /*FullyQualified*/);

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra updated this revision to Diff 61821. sivachandra added a comment. A little adjustment. http://reviews.llvm.org/D21666 Files: include/clang/AST/NestedNameSpecifier.h include/clang/Tooling/Core/QualTypeNames.h lib/AST/NestedNameSpecifier.cpp lib/Tooling/Core/QualTypeNames.cpp

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

rnk added inline comments. Comment at: lib/AST/NestedNameSpecifier.cpp:50 @@ +49,3 @@ + + NestedNameSpecifier *P = const_cast(Specifier); + while (P->getPrefix() != nullptr) { Doesn't this mutate the AST in place? We shouldn't be doing that. Co

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

saugustine accepted this revision. saugustine added a comment. This revision is now accepted and ready to land. This looks good and useful to me on the Tooling/Core side, but someone more familiar with the internals of NestedNamesSpecifiers should sign off on that portion. Also, I would probabl

[PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra created this revision. sivachandra added reviewers: rnk, saugustine. sivachandra added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D21666 Files: include/clang/AST/NestedNameSpecifier.h include/clang/Tooling/Core/QualTypeNames.h lib/AST/N