Re: [PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

2016-07-24 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r276595 https://reviews.llvm.org/D21717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

2016-07-24 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I think I'm happy with libc++'s behavior of automatically deducing the dtor exception specification. This patch LGTM. https://reviews.llvm.org/D21717

Re: [PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

2016-06-27 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT updated this revision to Diff 62001. STL_MSFT added a comment. Adding test_macros.h as requested. http://reviews.llvm.org/D21717 Files: test/std/containers/associative/map/map.cons/dtor_noexcept.pass.cpp test/std/containers/associative/multimap/multimap.cons/dtor_noexcept.pass.cpp

Re: [PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

2016-06-26 Thread Eric Fiselier via cfe-commits
EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Please add the missing "test_macros.h" includes. http://reviews.llvm.org/D21717 ___ cfe-commits mailing list

[PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

2016-06-24 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make dtor_noexcept.pass.cpp tests more portable. They were static_asserting that in certain situations, the following things have throwing destructors: ordered/unordered