This revision was automatically updated to reflect the committed changes.
Closed by commit rL280360: [analyzer] Add more FileIDs to PlistDiagnostic map
to avoid assertion (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D22090?vs=68987=69993#toc
Repository:
rL LLVM
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D22090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
a.sidorin updated this revision to Diff 68987.
a.sidorin added a comment.
Add plist output; give test files meaningful names.
https://reviews.llvm.org/D22090
Files:
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
zaks.anna added a comment.
https://reviews.llvm.org/D22090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added inline comments.
Comment at: test/Analysis/diagnostics/Inputs/include/Something.h:1
@@ +1,2 @@
+void clang_analyzer_warnIfReached();
+
Please, choose better file names. Every test that adds something cannot add a
header called something:) It
a.sidorin created this revision.
a.sidorin added reviewers: zaks.anna, dcoughlin.
a.sidorin added a subscriber: cfe-commits.
Some FileIDs that may be used by PlistDiagnostics are not added while building
a list of pieces. This leads to assertion violation in `GetFID()` function.
This patch
