Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-15 Thread Kirill Bobyrev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL275545: [clang-rename] add few tests (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D22102?vs=63939=64119#toc Repository: rL LLVM https://reviews.llvm.org/D22102 Files:

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @vmiklos sure thing. Thanks for noticing! http://reviews.llvm.org/D22102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63939. http://reviews.llvm.org/D22102 Files: test/clang-rename/FunctionMacro.cpp test/clang-rename/Namespace.cpp test/clang-rename/TemplateTypename.cpp test/clang-rename/UserDefinedConversion.cpp test/clang-rename/VariableMacro.cpp Index:

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Miklos Vajna via cfe-commits
vmiklos added a subscriber: vmiklos. vmiklos added a comment. Can you please avoid adding VirtualFunction.cpp? http://reviews.llvm.org/D22237 would add it as well, but without the FIXME. Thanks! :-) http://reviews.llvm.org/D22102 ___ cfe-commits

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Thanks, Manuel! Can you please land it? http://reviews.llvm.org/D22102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D22102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 marked an inline comment as done. omtcyf0 added a comment. Oops, sorry. Fixed it. +1 currently unsupported test. http://reviews.llvm.org/D22102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63934. http://reviews.llvm.org/D22102 Files: test/clang-rename/FunctionMacro.cpp test/clang-rename/Namespace.cpp test/clang-rename/TemplateTypename.cpp test/clang-rename/UserDefinedConversion.cpp test/clang-rename/VariableMacro.cpp

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-14 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: test/clang-rename/TemplateTypename.cpp:4 @@ +3,3 @@ +// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s +// XFAIL: * + Here, too? http://reviews.llvm.org/D22102 ___ cfe-commits

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-12 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63647. http://reviews.llvm.org/D22102 Files: test/clang-rename/FunctionMacro.cpp test/clang-rename/Namespace.cpp test/clang-rename/TemplateTypename.cpp test/clang-rename/VariableMacro.cpp test/clang-rename/VirtualFunction.cpp Index:

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-11 Thread Manuel Klimek via cfe-commits
klimek added a comment. Add // FIXME: to tests that do not work yet. I'd personally not check in the XFAIL tests for now, and just add them when you implement the missing functionality; the problem with XFAIL here is that (due to the offsets involved) they can easily switch into a mode where

Re: [PATCH] D22102: [clang-rename] extend testset

2016-07-11 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63470. omtcyf0 added a comment. add XFAIL test with virtual function renaming http://reviews.llvm.org/D22102 Files: test/clang-rename/FunctionMacro.cpp test/clang-rename/Namespace.cpp test/clang-rename/TemplateTypename.cpp

[PATCH] D22102: [clang-rename] extend testset

2016-07-07 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, klimek, bkramer, ioeric. omtcyf0 added a subscriber: cfe-commits. This patch introduces few additional tests including one case the tool does not handle yet, which should be fixed in the future. http://reviews.llvm.org/D22102