Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rL275895: [Driver] Compute effective target triples once per job (NFCI) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D22290?vs=64023=64367#toc Repository: rL LLVM

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

vsk updated this revision to Diff 64023. vsk added a comment. - Addressed Paul's comment: added a release note about this. - Rebased onto master to pick up an Xray change. https://reviews.llvm.org/D22290 Files: docs/ReleaseNotes.rst include/clang/Driver/Driver.h

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

probinson added a subscriber: probinson. probinson added a comment. On the thread you suggested it would affect out-of-tree targets, so this probably deserves a release note? https://reviews.llvm.org/D22290 ___ cfe-commits mailing list

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On 2016-Jul-13, at 11:18, Vedant Kumar wrote: > >> >> On Jul 13, 2016, at 10:30 AM, Duncan P. N. Exon Smith >> wrote: >> >> >>> On 2016-Jul-12, at 18:59, Vedant Kumar wrote: >>> On Jul 12, 2016, at 6:23 PM, Duncan P. N.

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On Jul 13, 2016, at 10:30 AM, Duncan P. N. Exon Smith > wrote: > > >> On 2016-Jul-12, at 18:59, Vedant Kumar wrote: >> >>> >>> On Jul 12, 2016, at 6:23 PM, Duncan P. N. Exon Smith >>> wrote: >>> >>> On 2016-Jul-12, at

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On 2016-Jul-12, at 18:59, Vedant Kumar wrote: > >> >> On Jul 12, 2016, at 6:23 PM, Duncan P. N. Exon Smith >> wrote: >> >> >>> On 2016-Jul-12, at 17:47, Vedant Kumar wrote: >>> >>> On Jul 12, 2016, at 5:41 PM, Duncan P. N.

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On Jul 12, 2016, at 6:23 PM, Duncan P. N. Exon Smith > wrote: > > >> On 2016-Jul-12, at 17:47, Vedant Kumar wrote: >> >> >>> On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith >>> wrote: >>> >>> On 2016-Jul-12, at

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On 2016-Jul-12, at 17:47, Vedant Kumar wrote: > > >> On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith >> wrote: >> >> >>> On 2016-Jul-12, at 16:53, Vedant Kumar wrote: >>> >>> vsk created this revision. >>> vsk added a reviewer:

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On Jul 12, 2016, at 5:47 PM, Vedant Kumar via cfe-commits > wrote: > >> >> On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith >> wrote: >> >> >>> On 2016-Jul-12, at 16:53, Vedant Kumar wrote: >>> >>> vsk created this

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith > wrote: > > >> On 2016-Jul-12, at 16:53, Vedant Kumar wrote: >> >> vsk created this revision. >> vsk added a reviewer: dexonsmith. >> vsk added a subscriber: cfe-commits. >> Herald added

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On 2016-Jul-12, at 16:53, Vedant Kumar wrote: > > vsk created this revision. > vsk added a reviewer: dexonsmith. > vsk added a subscriber: cfe-commits. > Herald added subscribers: srhines, danalbert, tberghammer, aemerson. > > Compute an effective target triple exactly once

[PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

vsk created this revision. vsk added a reviewer: dexonsmith. vsk added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, aemerson. Compute an effective target triple exactly once in ConstructJob(), and then simply pass around const references to it. This