Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-25 Thread Oliver Stannard via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL276625: [libunwind][ARM] Add support for Thumb1 targets (authored by olista01). Changed prior to commit: https://reviews.llvm.org/D22292?vs=65039&id=65317#toc Repository: rL LLVM https://reviews.llv

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-22 Thread Weiming Zhao via cfe-commits
weimingz added a comment. LGTM. Maybe @renato can review it too. Thanks Oliver and Saleem. https://reviews.llvm.org/D22292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-22 Thread Oliver Stannard via cfe-commits
olista01 updated this revision to Diff 65039. olista01 added a comment. - ADD must be ADDS for Thumb1 (previous patch was an old version uploaded by mistake) https://reviews.llvm.org/D22292 Files: src/UnwindRegistersRestore.S src/UnwindRegistersSave.S Index: src/UnwindRegistersSave.S

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-22 Thread Oliver Stannard via cfe-commits
olista01 added inline comments. Comment at: src/UnwindRegistersRestore.S:325-336 @@ -324,5 +324,14 @@ DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv) -#if !defined(__ARM_ARCH_ISA_ARM) - ldr r2, [r0, #52] - ldr r3, [r0, #60] +#if !defined

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-22 Thread Oliver Stannard via cfe-commits
olista01 updated this revision to Diff 65037. olista01 added a comment. Herald added a subscriber: samparker. - Don't save/restore r12 - Use LDM when restoring r8-r11 https://reviews.llvm.org/D22292 Files: src/UnwindRegistersRestore.S src/UnwindRegistersSave.S Index: src/UnwindRegistersSav

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-21 Thread Renato Golin via cfe-commits
rengolin added inline comments. Comment at: src/UnwindRegistersRestore.S:325 @@ -324,4 +324,3 @@ DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv) -#if !defined(__ARM_ARCH_ISA_ARM) - ldr r2, [r0, #52] - ldr r3, [r0, #60] +#if !defined(__AR

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-18 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: src/UnwindRegistersRestore.S:331 @@ +330,3 @@ + ldr r4, [r0, #0x2c] + ldr r5, [r0, #0x30] + mov r8, r1 Is there a benefit to doing the explicit loading rather than a add + ldm? Comment at: src/Unwind

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-18 Thread Ben Craig via cfe-commits
bcraig added a subscriber: bcraig. Comment at: src/UnwindRegistersRestore.S:325 @@ -324,4 +324,3 @@ DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv) -#if !defined(__ARM_ARCH_ISA_ARM) - ldr r2, [r0, #52] - ldr r3, [r0, #60] +#if !defined(_

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-18 Thread Weiming Zhao via cfe-commits
weimingz added inline comments. Comment at: src/UnwindRegistersRestore.S:326 @@ +325,3 @@ +#if !defined(__ARM_ARCH_ISA_ARM) && __ARM_ARCH_ISA_THUMB == 1 + @ r8-r12: ldr into r1-r5, then mov to r8-r12 + ldr r1, [r0, #0x20] weimingz wrote: > originally, r0-r7 get

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-18 Thread Weiming Zhao via cfe-commits
weimingz added inline comments. Comment at: src/UnwindRegistersRestore.S:325 @@ -324,4 +324,3 @@ DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv) -#if !defined(__ARM_ARCH_ISA_ARM) - ldr r2, [r0, #52] - ldr r3, [r0, #60] +#if !defined(__AR

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-18 Thread Oliver Stannard via cfe-commits
olista01 updated this revision to Diff 64318. https://reviews.llvm.org/D22292 Files: src/UnwindRegistersRestore.S src/UnwindRegistersSave.S Index: src/UnwindRegistersSave.S === --- src/UnwindRegistersSave.S +++ src/UnwindRegiste

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-15 Thread Asiri Rathnayake via cfe-commits
rmaprath added a subscriber: olista01. rmaprath added a comment. Update: We've hit a minor issue with the patch, we're confident it can be sorted by next week. I will ask @olista01 to put the final patch for review next week, as I'm on holidays. Hope this is OK. Cheers, / Asiri https://revie

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-14 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. Update: Almost there, should be able to put it up for review tomorrow. Cheers, / Asiri https://reviews.llvm.org/D22292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-13 Thread Weiming Zhao via cfe-commits
weimingz added a comment. In http://reviews.llvm.org/D22292#482750, @rmaprath wrote: > In http://reviews.llvm.org/D22292#482560, @compnerd wrote: > > > Can you explain why the write back is needed? You are doing the write back > > on r0, but then adjusting it back. So it is unclear why this ch

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-13 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. In http://reviews.llvm.org/D22292#482560, @compnerd wrote: > Can you explain why the write back is needed? You are doing the write back > on r0, but then adjusting it back. So it is unclear why this change is > needed. Could you provide some more context. A test ca

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-12 Thread Saleem Abdulrasool via cfe-commits
compnerd added a subscriber: compnerd. compnerd added a comment. Can you explain why the write back is needed? You are doing the write back on r0, but then adjusting it back. So it is unclear why this change is needed. Could you provide some more context. A test case would be even better.

[PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-12 Thread Weiming Zhao via cfe-commits
weimingz created this revision. weimingz added reviewers: rengolin, rmaprath. weimingz added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. ARMv6-m requires the writeback suffix for stm. http://reviews.llvm.org/D22292 Files: src/UnwindRegistersSave.S Index: src/Unwi