On Mon, Aug 1, 2016 at 6:48 AM, Jonathan Coe wrote:
> Thanks for reporting this.
>
> I can reproduce the segfault and have a fix. Is it ok to commit and have
> review done later?
Yes, this sort of thing is typical to handle post-commit (along with
other feedback that comes in post-commit).
~Aaro
Patch posted to Phabricator as https://reviews.llvm.org/D23008
regards,
Jon
On 1 August 2016 at 11:48, Jonathan Coe wrote:
> Thanks for reporting this.
>
> I can reproduce the segfault and have a fix. Is it ok to commit and have
> review done later?
>
> regards,
>
> Jon
>
> On 1 August 2016 at
Thanks for reporting this.
I can reproduce the segfault and have a fix. Is it ok to commit and have
review done later?
regards,
Jon
On 1 August 2016 at 11:06, Eric Lemanissier
wrote:
> ericLemanissier added a comment.
>
> I have an segfault on all the source files of my project when I enable
ericLemanissier added a comment.
I have an segfault on all the source files of my project when I enable this
check (it works ok when I disable this check). Sorry I don't have time to post
a minimal source file producing the segfault. I will maybe tomorrow, or in two
weeks.
Repository:
rL LL
alexfh added a comment.
Thanks for the new check! Looks awesome! A couple of late comments inline.
Comment at:
clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:91
@@ +90,3 @@
+
+ std::initializer_list>
+ Matchers = {{"dtor", SpecialMemb
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277262: [clang-tidy] add check
cppcoreguidelines-special-member-functions (authored by jbcoe).
Changed prior to commit:
https://reviews.llvm.org/D22513?vs=66161&id=66219#toc
Repository:
rL LLVM
http
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the check! The oddness with the DenseMap can wait until a
follow-up patch, btw.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
___
jbcoe marked 9 inline comments as done.
jbcoe added a comment.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe set the repository for this revision to rL LLVM.
jbcoe updated this revision to Diff 66161.
jbcoe added a comment.
Fix MSVC warning.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelines
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:60
@@ +59,3 @@
+ }
+}
+
Btw, with MSVC, this will give you a "not all control paths return a value"
warning. You should put an llvm_unreachable() after
jbcoe added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:62
@@ +61,3 @@
+std::string
+SpecialMemberFunctionsCheck::join(llvm::ArrayRef
SMFS,
+ llvm::StringRef AndOr) {
aaron.ballman wrote:
>
jbcoe updated this revision to Diff 66011.
jbcoe added a comment.
Minor changes from review.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsC
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:62
@@ +61,3 @@
+std::string
+SpecialMemberFunctionsCheck::join(llvm::ArrayRef
SMFS,
+ llvm::StringRef AndOr) {
I think this j
13 matches
Mail list logo
