Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

2016-09-19 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r276271. Please specify Differential revision in commit message. https://reviews.llvm.org/D22577 ___ cfe-commits

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

2016-07-20 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D22577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

2016-07-20 Thread Adrian McCarthy via cfe-commits
amccarth marked 2 inline comments as done. amccarth added a comment. https://reviews.llvm.org/D22577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

2016-07-20 Thread Adrian McCarthy via cfe-commits
amccarth updated this revision to Diff 64761. amccarth added a comment. Addressed feedback. https://reviews.llvm.org/D22577 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-dup-fwd-decl.cpp test/CodeGenCXX/debug-info-ms-abi.cpp

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

2016-07-20 Thread Reid Kleckner via cfe-commits
rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1096 @@ +1095,3 @@ + QualType Ty = CGM.getContext().getTypeDeclType(RD); + llvm::DIType *nestedType = getOrCreateType(Ty, getOrCreateMainFile()); + elements.push_back(nestedType); Is

[PATCH] D22577: Include unreferenced nested types in member list only for CodeView

2016-07-20 Thread Adrian McCarthy via cfe-commits
amccarth created this revision. amccarth added reviewers: rnk, dblaikie. amccarth added a subscriber: cfe-commits. Unreferenced nested structs and classes were omitted from the debug info. In DWARF, this was intentional, to avoid bloat. But, for CodeView, we want this information to be