Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-28 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. LGTM! Repository: rL LLVM https://reviews.llvm.org/D22637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-27 Thread Aaron En Ye Shi via cfe-commits
ashi1 updated this revision to Diff 65773. ashi1 marked an inline comment as done. ashi1 added a comment. Removed indentation as per Anastasia's comments. Repository: rL LLVM https://reviews.llvm.org/D22637 Files: include/clang/Basic/OpenCLExtensions.def lib/Basic/Targets.cpp

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-27 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188 @@ +187,3 @@ + #endif +#else + #ifdef cl_khr_mipmap_image Looks good! Could you just remove indentation please as it's not common for C macros? The same for the test

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-26 Thread Aaron En Ye Shi via cfe-commits
ashi1 updated this revision to Diff 65582. ashi1 added a comment. Revised based on Anastasia's comments. Restructured the if statements in test cases. Repository: rL LLVM https://reviews.llvm.org/D22637 Files: include/clang/Basic/OpenCLExtensions.def lib/Basic/Targets.cpp

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-26 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-version.cl:228 @@ +227,3 @@ +#endif +// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}} +#else Anastasia wrote: > ashi1 wrote: > > Anastasia wrote: > > >

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-26 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188 @@ +187,3 @@ +#endif +// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}} +#else ashi1 wrote: > yaxunl wrote: > > Anastasia wrote: > > >

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-25 Thread Aaron En Ye Shi via cfe-commits
ashi1 added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188 @@ +187,3 @@ +#endif +// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}} +#else yaxunl wrote: > Anastasia wrote: > > Can you move this error

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-25 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188 @@ +187,3 @@ +#endif +// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}} +#else Anastasia wrote: > Can you move this error message down

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-25 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188 @@ +187,3 @@ +#endif +// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}} +#else Can you move this error message down instead of adding 6

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-22 Thread Yaxun Liu via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM https://reviews.llvm.org/D22637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-22 Thread Aaron En Ye Shi via cfe-commits
ashi1 updated this revision to Diff 65126. ashi1 marked an inline comment as done. ashi1 added a comment. Revised based on Sam's comments. Repository: rL LLVM https://reviews.llvm.org/D22637 Files: include/clang/Basic/OpenCLExtensions.def lib/Basic/Targets.cpp

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-22 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:190 @@ +189,3 @@ +// expected-warning@-1{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}} +#endif + we also need to check the else case for `__OPENCL_C_VERSION__ <

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-22 Thread Aaron En Ye Shi via cfe-commits
ashi1 updated this revision to Diff 65118. ashi1 marked an inline comment as done. ashi1 added a comment. Revised based on Sam's comments. Added to tests Misc\amdgcn.languageOptsOpenCL.cl and SemaOpenCL\extension-version.cl Repository: rL LLVM https://reviews.llvm.org/D22637 Files:

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-21 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: include/clang/Basic/OpenCLExtensions.def:73 @@ -72,2 +72,3 @@ OPENCLEXT_INTERNAL(cl_khr_terminate_context, 200, ~0U) +OPENCLEXT_INTERNAL(cl_khr_mipmap_image, 200, ~0U) Better to follow the alphabetical order.

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-21 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. Need to add a test to Misc/amdgcn.languageOptsOpenCL.cl and SemaOpenCL/extension-version.cl Repository: rL LLVM https://reviews.llvm.org/D22637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-21 Thread Aaron En Ye Shi via cfe-commits
ashi1 created this revision. ashi1 added reviewers: yaxunl, Anastasia. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. Adding extension cl_khr_mipmap_image to clang's OpenCL Extensions and initiated inside AMDGPU Target. Repository: rL LLVM