alexfh added a comment.
My last comment might come across as somewhat harsh. I didn't mean it to be
harsh and just wanted to say that imo, llvm code is not ready to mechanically
applying IWYU.
Repository:
rL LLVM
https://reviews.llvm.org/D22656
___
alexfh added a comment.
In https://reviews.llvm.org/D22656#493036, @Eugene.Zelenko wrote:
> Don't include DiagnosticIDs.h.
This header is just an example. I don't want anyone (including myself) manually
figure out which of the headers inserted by IWYU actually need to be inserted.
I'm also ag
Eugene.Zelenko updated this revision to Diff 65099.
Eugene.Zelenko added a comment.
Don't include DiagnosticIDs.h.
Repository:
rL LLVM
https://reviews.llvm.org/D22656
Files:
clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp
Index: clang-apply-replacements/tool/ClangApplyReplace
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
In many cases a transitively included header can be considered a part of a
public interface of an already included header, e.g. it's reasonable to assume
that DiagnosticIDs.h is a pa
Eugene.Zelenko updated this revision to Diff 65004.
Eugene.Zelenko added a comment.
Full context diff.
Repository:
rL LLVM
https://reviews.llvm.org/D22656
Files:
clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp
Index: clang-apply-replacements/tool/ClangApplyReplacementsMain.cp
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Full context diffs, please. See
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Repository:
rL LLVM
https://reviews.llvm.org/D22656
___
Eugene.Zelenko created this revision.
Eugene.Zelenko added a reviewer: alexfh.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
rL LLVM
https://review
