Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

2016-07-27 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

2016-07-27 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/CodeGen/CGStmtOpenMP.cpp:3410-3411 @@ +3409,4 @@ + llvm::DenseSet EmittedAsFirstprivate; + CGCapturedStmtInfo CapturesInfo(cast(*D.getAssociatedStmt())); + for (const auto *C : D.getClausesOfKind()) {

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

2016-07-27 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 65810. sfantao marked 8 inline comments as done. sfantao added a comment. - Remove unnecessary brief directives and refactor target data privatization code genenration. https://reviews.llvm.org/D22691 Files: include/clang/AST/OpenMPClause.h lib/AST/Ope

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

2016-07-24 Thread Alexey Bataev via cfe-commits
ABataev requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/AST/OpenMPClause.h:4252 @@ -4237,1 +4251,3 @@ + + /// \brief Build clause with number of variables \a NumVars. /// No \brief

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

2016-07-22 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 65123. sfantao added a comment. - Use the correct enumerator for return pointer, as specified in the design document. https://reviews.llvm.org/D22691 Files: include/clang/AST/OpenMPClause.h lib/AST/OpenMPClause.cpp lib/CodeGen/CGOpenMPRuntime.cpp l

[PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

2016-07-22 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: cfe-commits, caomhin. This patch adds support for the use_device_ptr clause. It includes changes in SEMA that could not be tested without codegen, namely, the