hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D22702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jasonliu marked an inline comment as done.
jasonliu added a comment.
Gentle ping?
https://reviews.llvm.org/D22702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jasonliu marked an inline comment as done.
Comment at: test/std/re/re.regex/re.regex.construct/ptr_size.pass.cpp:31
@@ +30,3 @@
+test("\\(a\\)", 5, 0);
+test("\\(a[bc]\\)", 9, 0);
+test("\\(a\\([bc]\\)\\)", 13, 0);
Comment addressed in the new patch.
jasonliu updated this revision to Diff 66153.
jasonliu added a comment.
Address @hubert.reinterpretcast 's comment about the test case. Added more
cases to test "size" parameter in the constructor.
https://reviews.llvm.org/D22702
Files:
include/regex
hubert.reinterpretcast added a comment.
Minor concerns noted. I'd be okay with this patch, but would like someone else
to give the okay (or indicate what issues need to be addressed).
Comment at: include/regex:148
@@ -147,3 +147,3 @@
explicit basic_regex(const charT* p,
jasonliu created this revision.
jasonliu added reviewers: mclow.lists, rsmith, hubert.reinterpretcast.
jasonliu added a subscriber: cfe-commits.
Standard 28.8 p3 indicates the 3-argument constructor have a default argument
for flag_type parameter:
basic_regex(const charT* p, size_t len,
