This revision was automatically updated to reflect the committed changes.
Closed by commit rL284782: [clang] Remove FileEntry copy-constructor (authored
by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D22712?vs=65187&id=75356#toc
Repository:
rL LLVM
https://reviews.llvm.org/
bkramer accepted this revision.
bkramer added a comment.
GCC 4.7 is dead. Go ahead if it compiles.
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap added a comment.
i see, thanks. So do i understand correctly that we can proceed with this patch
?
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
vsk added a comment.
I believe gcc 4.7 and msvc 2013 are now unsupported (see e.g r284729).
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap added a comment.
@bkramer ?
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap added a comment.
two separate observations:
1. **without my changes** :
I checked the following revision: r276508 | rsmith | 2016-07-22 19:32:21
(with gcc 4.7.4, g++ 4.7.4, Ubuntu 16.04.1 LTS)
build of llvm/clang failed, the logs are here: https://reviews.llvm.org/P6916
(emplace is one
bkramer added a comment.
As far as I know we still support GCC 4.7, which doesn't have emplace in
std::map. I don't think this patch will work with 4.7. Should we drop support
for 4.7?
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
c
alexshap added a comment.
no, i don't.
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Do you have commit access?
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@list
alexshap created this revision.
alexshap added reviewers: bkramer, jdennett.
alexshap added subscribers: compnerd, cfe-commits.
alexshap changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
Code cleanup: address FIXME in
llvm/tools/clang/include/
10 matches
Mail list logo
