This revision was automatically updated to reflect the committed changes.
Closed by commit rL276769: Modules: add command line option
fmodules-disable-diagnostic-validation (authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D22773?vs=65449&id=65548#toc
Repository:
rL LLVM
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D22773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
manmanren updated this revision to Diff 65449.
manmanren added a comment.
Addressing Ben's comments
https://reviews.llvm.org/D22773
Files:
include/clang/Driver/Options.td
include/clang/Lex/HeaderSearchOptions.h
include/clang/Serialization/ASTReader.h
lib/Frontend/CompilerInvocation.cpp
manmanren added a comment.
In https://reviews.llvm.org/D22773#495524, @benlangmuir wrote:
> > the pcm could still be rewritten by a compilation that doesn't use a PCH,
> > and then it would be out of date because of the timestamp instead of the
> > diagnostic options
>
> >
>
> > "a compilation
benlangmuir added a comment.
> the pcm could still be rewritten by a compilation that doesn't use a PCH, and
> then it would be out of date because of the timestamp instead of the
> diagnostic options
>
> "a compilation that doesn't use a PCH", is that a different project? And we
> have two
manmanren added a comment.
In https://reviews.llvm.org/D22773#495403, @benlangmuir wrote:
> We need to add this option to the module hash (see getModuleHash - we already
> add a bunch of other HSOpts there). Otherwise the pcm could still be
> rewritten by a compilation that doesn't use a PCH,
benlangmuir added a comment.
We need to add this option to the module hash (see getModuleHash - we already
add a bunch of other HSOpts there). Otherwise the pcm could still be rewritten
by a compilation that doesn't use a PCH, and then it would be out of date
because of the timestamp instead o
manmanren created this revision.
manmanren added a reviewer: benlangmuir.
manmanren added a subscriber: cfe-commits.
With PCH+Module, sometimes compiler gives a hard error:
"Module file ‘.pcm' is out of date and needs to be rebuilt"
This happens when we have a PCH importing a module and the modul
