Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

alexfh added a comment. In https://reviews.llvm.org/D22853#503303, @chapuni wrote: > Seems a couple of tests would be incompatible to -fdelayed-template-parsing. > Appeased in r277452. Thank you! And sorry for the inconvenience. Repository: rL LLVM https://reviews.llvm.org/D22853

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

chapuni added a subscriber: chapuni. chapuni added a comment. Seems a couple of tests would be incompatible to -fdelayed-template-parsing. Appeased in r277452. Repository: rL LLVM https://reviews.llvm.org/D22853 ___ cfe-commits mailing list

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

This revision was automatically updated to reflect the committed changes. Closed by commit rL277437: [clang-rename] add support for template parameter renaming (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D22853?vs=66373=66446#toc Repository: rL LLVM

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-rename/USRFinder.cpp:80 @@ -79,1 +79,3 @@ TypeBeginLoc, 0, Context.getSourceManager(), Context.getLangOpts()); +if (const auto

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

omtcyfz updated this revision to Diff 66373. omtcyfz added a comment. Apply `clang-format` to fit 80 cols limit. https://reviews.llvm.org/D22853 Files: clang-rename/USRFinder.cpp clang-rename/USRLocFinder.cpp test/clang-rename/TemplateTypenameFindByTemplateParam.cpp

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

omtcyfz marked 3 inline comments as done. omtcyfz added a comment. https://reviews.llvm.org/D22853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

omtcyfz updated this revision to Diff 66372. omtcyfz added a comment. Addressed comments; updated to the latest revision. https://reviews.llvm.org/D22853 Files: clang-rename/USRFinder.cpp clang-rename/USRLocFinder.cpp test/clang-rename/TemplateTypenameFindByTemplateParam.cpp

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

omtcyfz added inline comments. Comment at: clang-rename/USRFinder.cpp:80 @@ -79,1 +79,3 @@ TypeBeginLoc, 0, Context.getSourceManager(), Context.getLangOpts()); +if (const auto *TemplateTypeParm = dyn_cast(Loc.getType())) { + return

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-rename/USRFinder.cpp:80 @@ -79,1 +79,3 @@ TypeBeginLoc, 0, Context.getSourceManager(), Context.getLangOpts()); +if (const auto *TemplateTypeParm =

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

omtcyfz updated this revision to Diff 66095. omtcyfz added a comment. git rebase; git resolve conflicts https://reviews.llvm.org/D22853 Files: clang-rename/USRFinder.cpp clang-rename/USRLocFinder.cpp test/clang-rename/TemplateTypenameFindByTemplateParam.cpp

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

omtcyfz added a comment. Ping. Change is quite trivial. https://reviews.llvm.org/D22853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22853: [clang-rename] add support for template parameter renaming

omtcyfz created this revision. omtcyfz added reviewers: alexfh, klimek. omtcyfz added a subscriber: cfe-commits. Few simple tweaks allow template parameters to be renamed. See TemplateTypenameFindBy{TemplateParam|TypeInside}.cpp for example how it works. https://reviews.llvm.org/D22853 Files: