Re: [PATCH] D23023: [include-fixer] Correct nested class search for identifiers with scoped information

2016-08-02 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL277442: [include-fixer] Correct nested class search for identifiers with scoped… (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23023?vs=66452&id=66454#toc Repository: rL LL

Re: [PATCH] D23023: [include-fixer] Correct nested class search for identifiers with scoped information

2016-08-02 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 66452. hokein added a comment. Address review comments. https://reviews.llvm.org/D23023 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.cpp include-fixer/SymbolIndexManager.cpp include-fixer/SymbolIndexManager.h unittests/in

Re: [PATCH] D23023: [include-fixer] Correct nested class search for identifiers with scoped information

2016-08-02 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. This revision is now accepted and ready to land. Comment at: include-fixer/SymbolIndexManager.h:32 @@ +31,3 @@ + /// \param IsNestedSearch Whether searching nested classes. If true, the + ///method tries to stripping identifier name parts

[PATCH] D23023: [include-fixer] Correct nested class search for identifiers with scoped information

2016-08-01 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. include-fixer will firstly try to use scoped namespace context information to search identifier. However, in some cases, it's unsafe to do nested class search, because it might treat the identif