This revision was automatically updated to reflect the committed changes.
Closed by commit rL281358: ObjectiveC Generics: Start using ObjCTypeParamType.
(authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D23080?vs=69765=71205#toc
Repository:
rL LLVM
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Ahhh, much cleaner. Thanks!
https://reviews.llvm.org/D23080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
manmanren updated the summary for this revision.
manmanren updated this revision to Diff 69765.
manmanren added a comment.
This patch is now much simpler with the updated version of
https://reviews.llvm.org/D23079.
https://reviews.llvm.org/D23080
Files:
lib/AST/ASTContext.cpp
manmanren added a comment.
I will update this patch once the 2nd patch is done.
Thanks for reviewing,
Manman
Comment at: lib/AST/Type.cpp:1095
@@ +1094,3 @@
+return ctx.getQualifiedType(argType, splitType.Quals);
+ // Apply protocol lists if exists. Should
doug.gregor requested changes to this revision.
doug.gregor added a comment.
This revision now requires changes to proceed.
I think most of the complexity here will fold away when ObjCTypeParamType
becomes sugar for the underlying ObjCObjectPointerType.
Comment at:
manmanren created this revision.
manmanren added a reviewer: doug.gregor.
manmanren added a subscriber: cfe-commits.
Depends on https://reviews.llvm.org/D23078 and https://reviews.llvm.org/D23079
We say ObjCTypeParamType is ObjCObjectPointerType, but we assert
fail when trying to call
