This revision was automatically updated to reflect the committed changes.
Closed by commit rL278851: [OpenCL] AMDGPU: Add extensions cl_amd_media_ops and
cl_amd_media_ops2 (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D23322?vs=67358=68250#toc
Repository:
rL LLVM
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D23322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yaxunl added a comment.
In https://reviews.llvm.org/D23322#513792, @Anastasia wrote:
> Do you think testing the declaration to be available without/with an error
> after the extension is enabled/disabled might be useful too?
I feel it is not so useful for a specific extension.
When the
Anastasia added a comment.
Do you think testing the declaration to be available without/with an error
after the extension is enabled/disabled might be useful too?
https://reviews.llvm.org/D23322
___
cfe-commits mailing list
yaxunl added a comment.
In https://reviews.llvm.org/D23322#512823, @Anastasia wrote:
> Ok, sure. Is the plan to refactor this bit in case we implement the generic
> support later then?
>
> It seems fine, although I can't check much without any documentation. Is
> there any reference available
Anastasia added a comment.
Ok, sure. Is the plan to refactor this bit in case we implement the generic
support later then?
It seems fine, although I can't check much without any documentation. Is there
any reference available online?
https://reviews.llvm.org/D23322
yaxunl added a comment.
In https://reviews.llvm.org/D23322#512732, @Anastasia wrote:
> Is this related to our discussion on cfe-dev about the extensions and also
> the earlier review you have created: https://reviews.llvm.org/D21698?
Since that feature takes time to implement, we decide to
Anastasia added a comment.
Is this related to our discussion on cfe-dev about the extensions and also the
earlier review you have created: https://reviews.llvm.org/D21698?
https://reviews.llvm.org/D23322
___
cfe-commits mailing list
yaxunl created this revision.
yaxunl added reviewers: nhaustov, Anastasia.
yaxunl added subscribers: cfe-commits, tstellarAMD.
Herald added a reviewer: tstellarAMD.
Herald added a subscriber: kzhuravl.
https://reviews.llvm.org/D23322
Files:
include/clang/Basic/OpenCLExtensions.def
